> On 20.12.2016, at 19:09, Timothy Walters <walters@xxxxxxxxxxxxxxxxxx> wrote: > > I fixed the ~note bug this morning, and found the test cases that I used when first writing the Scale/Tuning classes. I'll work up a test class, check for other breakage, and then submit a pull request (if I still have dev permission) or email a patch (if I don't). That’s excellent, thank you. You don’t need permission, you just make a change to your own fork of supercollider and make a pull request (note that recently the unit tests were moved from the quarks to the supercollider repository). > The scales and tunings in the library came from a variety of sources, some long forgotten. I probably erred on the side of inclusivity rather than reliability, but in a few cases (Partch, Carlos) I went directly to the source, so the only thing to watch out for would be transcription errors. I will try to find references for as many as possible, even if only on Wikipedia. Perfect (wikipedia can also be a good reference point). Again, thanks for doing all the tracing ... > > On 12/20/16 5:39 AM, Julian Rohrhuber wrote: >>> On 18.12.2016, at 17:36, Tim Walters <walters@xxxxxxxxxxxxxxxxxx> wrote: >>> >>> On 12/18/16 12:52 AM, Julian Rohrhuber wrote: >>>>> On 18.12.2016, at 03:33, Tim Walters <walters@xxxxxxxxxxxxxxxxxx> wrote: >>>>> >>>>>>> No, it doesn't. >>>>>> First, I should apologize for the heat of my reply. On a technical level, >>>>>> I'm quite sure I'm correct -- but the way I expressed it may not have been >>>>>> the most helpful. >>>>> I apologize in turn for getting hasty and defensive about code I haven't touched since 2009. It might not even be my issue! (Yeah, right...) >>>> and, sorry about my comments about the classes being unreliable, probably they are fine! Or are there any things that you think would deserve some work? >>> I think the "normal" use case--dropping it into a Pattern with the \scale key--is pretty solid, because I use that myself a lot. >> That is good to know. >> >>> But where there's one bug, there may very well be more. And while I tried to be careful about defining the built-in scales and tunings, I don't have academy-grade knowledge of that material at all, so there may be errors, omissions, and inadvertent generalizations. >> Perhaps we should try and write tests that vary all the edge cases of the classes for examples that are easy to understand? >> >> The rest might then be just proof-reading the scale and tuning data themselves. I vaguely remember you once mentioned the source for the scales, but I can’t find it anymore ... >> > > > _______________________________________________ > sc-users mailing list > > info (subscription, etc.): http://www.birmingham.ac.uk/facilities/ea-studios/research/supercollider/mailinglist.aspx > archive: https://listarc.bham.ac.uk/marchives/sc-users/ > search: https://listarc.bham.ac.uk/lists/sc-users/search/
Attachment:
signature.asc
Description: Message signed with OpenPGP using GPGMail