Re: [sc-users] Document keyUp

[Jan Trützschler <falkenst@xxxxxxxxx>]

aha, i see. so the keyDown must be changed too.
i can't do it tonight anymore, but i'll try  to do it tomorrow ...

-jan

On Dec 25, 2004, at 11:46 PM, James McCartney wrote:

> On Dec 25, 2004, at 2:30 PM, Jan Trützschler wrote:
>
> > as far as i can see this is called before the lock:
> >
> > 			PyrSymbol *method = getsym("keyUp");
> >
> > 			if (pobj) {
> > 				pthread_mutex_lock (&gLangMutex);
>
> yes, this is wrong. If another thread like a timer were to take the 
> lock and define a new symbol, then the getsym could crash.
> getsym must be done after the lock is taken.
>
> > > compiledOK must be tested again inside the lock.
> >
> > like this?
> >
> > 			PyrSymbol *method = getsym("keyUp");
> >
> > 			if (pobj) {
> > 				pthread_mutex_lock (&gLangMutex);
> > 				if(compiledOK){
> > 					....
> >
> > so is it neccessary to have check two times for  compiledOK ?
> yes, because in the meantime the value may have changed unless you own 
> the lock.
>
>
> _______________________________________________
> sc-users mailing list
> sc-users@xxxxxxxxxxxxxxx
> http://www.create.ucsb.edu/mailman/listinfo/sc-users