Re: [sc-users] Document keyUp

[Jan Trützschler <falkenst@xxxxxxxxx>]

On Dec 23, 2004, at 9:22 PM, James McCartney wrote:

> This change has two problems.
>
> You cannot call getsym safely outside the lock. move it inside the 
> lock.
>
> PyrSymbol *method = getsym("keyUp");

as far as i can see this is called before the lock:

			PyrSymbol *method = getsym("keyUp");

			if (pobj) {
				pthread_mutex_lock (&gLangMutex);


> compiledOK must be tested again inside the lock.

like this?

			PyrSymbol *method = getsym("keyUp");

			if (pobj) {
				pthread_mutex_lock (&gLangMutex);
				if(compiledOK){
					....

so is it neccessary to have check two times for  compiledOK ?

-jan

> On Dec 22, 2004, at 2:56 PM, Jan Trützschler wrote:
>
> > i added a keyUp method and  a keyUpAction to Document .
> > cu
> > -jan
>
> _______________________________________________
> sc-users mailing list
> sc-users@xxxxxxxxxxxxxxx
> http://www.create.ucsb.edu/mailman/listinfo/sc-users