[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [sc-dev] CondVar.new



On Wed, May 12, 2021 at 6:34 PM <mlang@xxxxxxxxxx> wrote:
> This looks suspicious, but I am reluctant to file a PR since the code is
> new and likely has been reviewed a lot.  So maybe I am missing
> something?
>
> CondVar {
>        var waitingThreads;
>
>        *new { ^super.newCopyArgs(Array.new, Array.new) }
>
> AIUI, CondVar has only one instance variable.
> Why does newCopyArgs pass in *two* empty arrays?

Looks like it's vestigial -- good catch. A PR is a good idea.

hjh

_______________________________________________
sc-dev mailing list

info (subscription, etc.): http://www.birmingham.ac.uk/facilities/ea-studios/research/supercollider/mailinglist.aspx
archive: https://listarc.bham.ac.uk/marchives/sc-dev/
search: https://listarc.bham.ac.uk/lists/sc-dev/search/