Re: [sc-dev] string.replace

[Scott Wilson <i@xxxxxxxxxxxxxx>]

Seems like we’re leaning char, but I’ll wait for others to chime in.

Based on a quick look there will be two parts to fixing this. One change prString_Find to accept chars, and two modify String:replace to not call the super version, since the calls to asArray on find and replace will also cause a problem.

This will mean that String:find will accept Chars as well, but that would make sense for symmetry anyway.

S.
 
> On 5 Dec 2015, at 10:52, adc <alberto.decampo@xxxxxxxxx> wrote:
> 
> my vote: support char, let nil fail 
> 
>> On 05/12/2015, at 11:40 , James Harkins <jamshark70@xxxxxx> wrote:
>> 
>> On December 5, 2015 6:07:23 PM Scott Wilson <i@xxxxxxxxxxxxxx> wrote:
>> 
>>> So any consensus? Leave as is with slight breakage and document, or support at least Char as well?
>> 
>> I say, support Char.
>> 
>> hjh
>> 
>> Sent with AquaMail for Android
>> http://www.aqua-mail.com
>> 
>> 
>> 
>> 
>> 
>> _______________________________________________
>> sc-dev mailing list
>> 
>> info (subscription, etc.): http://www.birmingham.ac.uk/facilities/ea-studios/research/supercollider/mailinglist.aspx
>> archive: https://listarc.bham.ac.uk/marchives/sc-dev/
>> search: https://listarc.bham.ac.uk/lists/sc-dev/search/
> 
> 
> _______________________________________________
> sc-dev mailing list
> 
> info (subscription, etc.): http://www.birmingham.ac.uk/facilities/ea-studios/research/supercollider/mailinglist.aspx
> archive: https://listarc.bham.ac.uk/marchives/sc-dev/
> search: https://listarc.bham.ac.uk/lists/sc-dev/search/


_______________________________________________
sc-dev mailing list

info (subscription, etc.): http://www.birmingham.ac.uk/facilities/ea-studios/research/supercollider/mailinglist.aspx
archive: https://listarc.bham.ac.uk/marchives/sc-dev/
search: https://listarc.bham.ac.uk/lists/sc-dev/search/