[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [sc-dev] dumpOSC



Thank you for looking into this!

I'm also not sure what the original idea was with that commit and dumpOSC. The patch has to do with reimplementation using boost::asio. Probably it was just a mistake and wasn't tested.

Your patch looks okay to me. If you've tested both UDP and TCP I say we commit it. Do you want to do this?

S.



On 24 Nov 2013, at 23:20, Open Music Kontrollers INFO <info@xxxxxxxxxxxxxxxxxxxxxxxxx> wrote:

>>> 
>>> 
> 
> It seems that the function calls for dumpOSC were altogether removed from the UDP and TCP listener callbacks.
> Cannot figure out why, though, either it was by purpose or its a bug.
> In any case, the following patch adds them again and fixes the issue on git HEAD.
> 
> diff --git a/server/scsynth/SC_ComPort.cpp b/server/scsynth/SC_ComPort.cpp
> index fbe91f6..d66fa9b 100644
> --- a/server/scsynth/SC_ComPort.cpp
> +++ b/server/scsynth/SC_ComPort.cpp
> @@ -219,6 +219,8 @@ class SC_UdpInPort
>              return;
>          }
>  
> +        if (mWorld->mDumpOSC) dumpOSC(mWorld->mDumpOSC, bytes_transferred, recvBuffer.data());
> +
>          OSC_Packet * packet = (OSC_Packet*)malloc(sizeof(OSC_Packet));
>  
>          packet->mReplyAddr.mProtocol = kUDP;
> @@ -368,6 +370,8 @@ private:
>  
>          assert(bytes_transferred == OSCMsgLength);
>  
> +        if (mWorld->mDumpOSC) dumpOSC(mWorld->mDumpOSC, bytes_transferred, data);
> +
>          OSC_Packet * packet = (OSC_Packet*)malloc(sizeof(OSC_Packet));
>  
>          packet->mReplyAddr.mProtocol = kTCP;
> 


_______________________________________________
sc-dev mailing list

info (subscription, etc.): http://www.beast.bham.ac.uk/research/sc_mailing_lists.shtml
archive: https://listarc.bham.ac.uk/marchives/sc-dev/
search: https://listarc.bham.ac.uk/lists/sc-dev/search/