[sc-dev] ErrorNotification?

[Fredrik Olofsson <f@xxxxxxxxxxxxxxxxxxx>]

hi list,
are mLocalErrorNotification and mErrorNotification really needed?  why  
not simplify and use verbosity -2 to suppress n_free and n_set  
errors?  seems more logical than the server \error message.


Index: Source/server/SC_Lib.cpp
===================================================================
--- Source/server/SC_Lib.cpp	(revision 9630)
+++ Source/server/SC_Lib.cpp	(working copy)
@@ -112,7 +112,7 @@
 	} catch (int iexc) {
 		err = iexc;
 	} catch (std::exception& exc) {
-		if(inWorld->mLocalErrorNotification <= 0 && inWorld- 
>mErrorNotification) {
+		if(inWorld->mVerbosity >= -1) {
 			CallSendFailureCommand(inWorld, (char*)Name(), exc.what(),  
inReply);
 			scprintf("FAILURE %s %s\n", (char*)Name(), exc.what());
 		}
@@ -120,7 +120,7 @@
 	} catch (...) {
 		err = kSCErr_Failed;
 	}
-	if (err && (inWorld->mLocalErrorNotification <= 0 && inWorld- 
>mErrorNotification)) {
+	if (err && (inWorld->mVerbosity >= -1)) {
 		const char *errstr = SC_ErrorString(err);
 		CallSendFailureCommand(inWorld, (char*)Name(), (char*)errstr,  
inReply);
 		scprintf("FAILURE %s %s\n", (char*)Name(), (char*)errstr);



at least there should be some info in ServerOptions' helpfile (under  
verbosity) that points to the \error message.  i'll add a reference  
later.
_f





  #|
     fredrikolofsson.com     klippav.org     musicalfieldsforever.com
  |#


_______________________________________________
sc-dev mailing list

info (subscription, etc.): http://www.beast.bham.ac.uk/research/sc_mailing_lists.shtml
archive: https://listarc.bham.ac.uk/marchives/sc-dev/
search: https://listarc.bham.ac.uk/lists/sc-dev/search/