[sc-dev] SF.net SVN: supercollider:[8305] trunk/build/SCClassLibrary/Common/Files/ Help.sc

[danstowell@xxxxxxxxxxxxxxxxxxxxx]

Revision: 8305
          http://supercollider.svn.sourceforge.net/supercollider/?rev=8305&view=rev
Author:   danstowell
Date:     2008-12-26 19:00:31 +0000 (Fri, 26 Dec 2008)

Log Message:
-----------
Help.gui - hide the text-file-opening buttons on windows, since in Psycollider they can cause bad crashes. This is a workaround. Hopefully one day the root cause can be fixed.

Modified Paths:
--------------
    trunk/build/SCClassLibrary/Common/Files/Help.sc

Modified: trunk/build/SCClassLibrary/Common/Files/Help.sc
===================================================================
--- trunk/build/SCClassLibrary/Common/Files/Help.sc	2008-12-26 18:45:08 UTC (rev 8304)
+++ trunk/build/SCClassLibrary/Common/Files/Help.sc	2008-12-26 19:00:31 UTC (rev 8305)
@@ -290,7 +290,8 @@
 						{
 							fHistoryDo.value( \open, fileslist.at( selecteditem.asSymbol ) ? fileslist.at( \Help ));
 						}.defer( 0.001 );
-						isClass = selecteditem.asSymbol.asClass.notNil;							classButt.enabled_(isClass);
+						isClass = selecteditem.asSymbol.asClass.notNil;
+                                                if(classButt.notNil){classButt.enabled_(isClass)};
 						browseButt.enabled_(isClass);
 						// The "selectednodes" entry for the leaf, is the path to the helpfile (or "")
 						selectednodes[index] = try { if(index==0, {tree}, {selectednodes[index-1]})
@@ -368,16 +369,22 @@
 	});
 	
 //	buttonView = GUI.hLayoutView.new(win, Rect(5, 530, 405, 20));
-	GUI.button.new( win, Rect( 5, /* 534 */ bounds.height - 30, 110, 20 ))
+        Platform.case(\windows, {
+            // TEMPORARY WORKAROUND:
+            // At present, opening text windows from GUI code can cause crashes on Psycollider
+            // (thread safety issue?). To work around this we just remove those buttons.
+        }, {
+            GUI.button.new( win, Rect( 5, /* 534 */ bounds.height - 30, 110, 20 ))
 		.states_([["Open Help File", Color.black, Color.clear]])
 		.action_({{ selecteditem.openHelpFile }.defer;});
-	classButt = GUI.button.new( win, Rect( 119, /* 534 */ bounds.height - 30, 110, 20 ))
+            classButt = GUI.button.new( win, Rect( 119, /* 534 */ bounds.height - 30, 110, 20 ))
 		.states_([["Open Class File", Color.black, Color.clear]])
 		.action_({ 
 			if(selecteditem.asSymbol.asClass.notNil, {
 				{selecteditem.asSymbol.asClass.openCodeFile }.defer;
 			});
 		});
+        });
 	browseButt = GUI.button.new( win, Rect( 233, /* 534 */ bounds.height - 30, 110, 20 ))
 		.states_([["Browse Class", Color.black, Color.clear]])
 		.action_({ 


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

_______________________________________________
sc-dev mailing list

info (subscription, etc.): http://www.beast.bham.ac.uk/research/sc_mailing_lists.shtml
archive: https://listarc.bham.ac.uk/marchives/sc-dev/
search: https://listarc.bham.ac.uk/lists/sc-dev/search/