Re: [sc-dev] SCTextView bugs

[Scott Wilson <s.d.wilson.1@xxxxxxxxxx>]

No worries. It was a little cryptic, but it makes sense once I figured  
it out!

S.

On 23 Dec 2008, at 22:56, blackrain wrote:

> hey Scott and all,
>
> I believe that's my fault in some part.
> if I recall right (would have to scroll thru th archives), when felix
> asked about this, I sent a patch w/o the line you mention being
> commented out.
> I realized mins later and posted about it but the first patch had
> already been commited.
> I didnt fix it cuz I forgot and the issue was left there.
>
> thanks for taking care of that.
>
> cheers,
>
> x
>
> On Wed, Dec 24, 2008 at 12:30 AM, Scott Wilson <s.d.wilson.1@xxxxxxxxxx 
> > wrote:
> > On 23 Dec 2008, at 16:37, Scott Wilson wrote:
> >
> > Execute the following, scroll down, and then click on the post  
> > window. The
> > text view scrolls back to the top and the scroller disappears.
> > Also it often seems to happen the text view doesn't wrap correctly,  
> > and the
> > text is hidden behind the vertical scroll bar.
> > S.
> > (
> > w = SCWindow.new("Text View
> > Example",Rect(100,SCWindow.screenBounds.height-400, 520,300)).front;
> > t = SCTextView(w.asView,Rect(10,10, 500,200));
> > t.hasVerticalScroller_(true);
> > t.open("Help/Help.html");  // load an html file
> > )
> >
> > Okay, the following diff seems to fix the first bug, and maybe the  
> > second
> > one too.
> > Index: /code/SuperCollider/Source/app/SCCocoaView.M
> > ===================================================================
> > --- /code/SuperCollider/Source/app/SCCocoaView.M (revision 8262)
> > +++ /code/SuperCollider/Source/app/SCCocoaView.M (working copy)
> > @@ -355,7 +355,7 @@
> >  mLayout.bounds = mBounds;
> >  }
> >  [mScrollView setFrame: SCtoNSRect(mLayout.bounds)];
> > - [mTextView setFrame: SCtoNSRect(mLayout.bounds)]; // not needed -  
> > br
> > + //[mTextView setFrame: SCtoNSRect(mLayout.bounds)]; // not needed  
> > - br
> >
> >  // [mScrollView setBounds: SCtoNSRect(mBounds)];
> >  // [mTextView setBounds: SCtoNSRect(mBounds)];
> > Seems br was correct! Not only not needed but messing things up.
> > I'll commit if there is no objection.
> > S.
>
> _______________________________________________
> sc-dev mailing list
>
> info (subscription, etc.): http://www.beast.bham.ac.uk/research/sc_mailing_lists.shtml
> archive: https://listarc.bham.ac.uk/marchives/sc-dev/
> search: https://listarc.bham.ac.uk/lists/sc-dev/search/


_______________________________________________
sc-dev mailing list

info (subscription, etc.): http://www.beast.bham.ac.uk/research/sc_mailing_lists.shtml
archive: https://listarc.bham.ac.uk/marchives/sc-dev/
search: https://listarc.bham.ac.uk/lists/sc-dev/search/