Re: [Sc-devel] Suggested change to SC_LanguageClient.cpp

["John Glover" <glover.john@xxxxxxxxx>]

Committed (r 7164)


John

On 30/01/2008, Christopher Frauenberger <frauenberger@xxxxxx> wrote:
> Yes, a good idea imo.
>
> Chris
>
>
> On 30 Jan 2008, at 12:30, Dan Stowell wrote:
>
> > Sounds sensible to me, to decouple python flag from windows flag.
> >
> > Dan
> >
> >
> > 2008/1/29, John Glover <glover.john@xxxxxxxxx>:
> >> Hi all,
> >>
> >> At line 315 of SC_LanguageClient.cpp  we have:
> >>
> >> // this is defined in PySCLang
> >> #ifndef SC_WIN32
> >>
> >> This assumes that PySCLang will only be compiled on windows. I would
> >> like to change this to:
> >>
> >> // this is defined in PySCLang
> >> #ifndef PYSCLANG
> >>
> >> and then make sure that any platform that PySCLang is compiled on has
> >> PYSCLANG defined.
> >>
> >> I'll commit a change if no one objects, I don't think it should
> >> effect
> >> Mac or Linux code anyway.
> >>
> >> I am working on a distutils script to build PySCLang on Linux. It
> >>
> >>
> >> Thanks,
> >> John
> >> _______________________________________________
> >> Sc-devel mailing list
> >> Sc-devel@xxxxxxxxxxxxxxx
> >> http://lists.create.ucsb.edu/mailman/listinfo/sc-devel
> >>
> >
> >
> > --
> > http://www.mcld.co.uk
> > _______________________________________________
> > Sc-devel mailing list
> > Sc-devel@xxxxxxxxxxxxxxx
> > http://lists.create.ucsb.edu/mailman/listinfo/sc-devel
>
> _______________________________________________
> Sc-devel mailing list
> Sc-devel@xxxxxxxxxxxxxxx
> http://lists.create.ucsb.edu/mailman/listinfo/sc-devel
>