[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Sc-devel] 3.2 RC cutoff time [was Re: Quarks and svn]

I didn't make that change, but in the latest svn update I just did, it appears to be gone... so, no warning!

I'm building with the current state of SC svn and quarks.



On Jan 27, 2008, at 5:27 PM, James Harkins wrote:

On Jan 27, 2008, at 8:20 PM, ronald kuivila wrote:

Hi Josh,

 I now see: 
WARNING: FunctionDef contains variable declarations and so will not be inlined.
   in file '/Common/GUI/PlusGUI/Control/ServerPlusGUI.sc'
   line 220 char 22:
  var volSpec, cpVol;•
  var volumeSlider, volumeNum, muteButton, muteActions, volController;

 Maybe that should be restructured - bad for our cred to have warnings in the release;)

I don't know why the variable declarations are not at the top of the method. We had...

makeWindow {
var ....;

blah blah blah

var ...;
volume gui code

???  and there's now an if() around that.

Why do we not just stick a VolumeGUI object in the window? MVC all the way thru baby. I don't see any good reason to repeat the VolumeGUI code in the makeWindow method.


: H. James Harkins

"Come said the Muse,
Sing me a song no poet has yet chanted,
Sing me the universal."  -- Whitman

Sc-devel mailing list


/* Joshua D. Parmenter


“Every composer – at all times and in all cases – gives his own interpretation of how modern society is structured: whether actively or passively, consciously or unconsciously, he makes choices in this regard. He may be conservative or he may subject himself to continual renewal; or he may strive for a revolutionary, historical or social palingenesis." - Luigi Nono