[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Sc-devel] 3.2 RC cutoff time [was Re: Quarks and svn]



On Jan 27, 2008, at 8:20 PM, ronald kuivila wrote:

Hi Josh,

 I now see: 
WARNING: FunctionDef contains variable declarations and so will not be inlined.
   in file '/Common/GUI/PlusGUI/Control/ServerPlusGUI.sc'
   line 220 char 22:
  var volSpec, cpVol;•
  var volumeSlider, volumeNum, muteButton, muteActions, volController;

 Maybe that should be restructured - bad for our cred to have warnings in the release;)

I don't know why the variable declarations are not at the top of the method. We had...

makeWindow {
var ....;

blah blah blah

{
var ...;
volume gui code
}.value;
}

???  and there's now an if() around that.

Why do we not just stick a VolumeGUI object in the window? MVC all the way thru baby. I don't see any good reason to repeat the VolumeGUI code in the makeWindow method.

hjh


: H. James Harkins

: jamshark70@xxxxxxxxxxxxxxxxx

: http://www.dewdrop-world.net

.::!:.:.......:.::........:..!.::.::...:..:...:.:.:.:..:


"Come said the Muse,

Sing me a song no poet has yet chanted,

Sing me the universal."  -- Whitman