[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Sc-devel] [commit?] MIDI about-to-commits?



Hiho,

I am about to commit a couple of improvements to the MIDI implementation:

sysex : divided up in a instance method sysex, and a primitive prSysex, as 
opposed to the previous instance method which called the primitive directly.
This drops the uid argument to the method, as this can be looked up in the 
instance variable.
This fix is necessary, because uid may be 0 which on Linux means that any 
connected MIDI client to that port will get the message.

(dis)connect methods:
a bug fix; previously you could not pass the uid to it, as it assumed that 
uid's are negative. This may be the case on OSX, but it isn't on Linux. New 
behaviour checks whether the device argument passed on is larger than the 
sizes of sources, and if so, it checks whether there is a source with that 
uid.

MIDIOut.new:
made default argument for uid 0.

linux only:
MIDIOut.connect and disconnect methods.


ok to commit?

(most stuff does not break code, only the first does)

sincerely,
Marije