[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[sc-dev] sc_coremidi bug



hi james, jan, others,
i believe there are little mistakes in the recent updates you added to SC_CoreMIDI.cpp 

line 129

uint8 status = pkt->data[0] & 0xF0;
uint8 chan = pkt->data[0] & 0x0F;

should be
uint8 status = pkt->data[i] & 0xF0;
uint8 chan = pkt->data[i] & 0x0F;


line 139
++g->sp; SetInt(g->sp,  pkt->data[1]); //val1
++g->sp; SetInt(g->sp,  pkt->data[2]); //val2

should be
++g->sp; SetInt(g->sp,  pkt->data[i + 1]); //val1
++g->sp; SetInt(g->sp,  pkt->data[i + 2]); //val2

...
etc. until line 174.


i don't think this is a problem in in patch file daniel has posted
since i did the diff manually myself and it worked

thnx,
tom


....................
....................