[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [sc-dev] [ ¿commit? ] Dseq arg changes

James McCartney wrote:
Perhaps it is Pseries that should be changed.
But that would break code. this change breaks less code I guess.
I dunno.
I see that there is a good reason to have one argument that is common to all Demand rate ugens as a first arg. But they are really similar to the pattern classes. Taking into acount that the argument name order is wrong currently, it would be good to change at least Dbrown and Dwhite. With Dseries, I think they would better adopt from Pseries than from Array.series, because the functionality is more related to the former. 
Is that reason enough to risk the change?




On Dec 6, 2004, at 3:23 PM, James McCartney wrote:



 I object.
 Dseries matches Array.series(size, start, step)
 Dgeom matches Array.geom(size, start, grow)

 On Dec 6, 2004, at 2:17 PM, Julian Rohrhuber wrote:
if noone objects I will commit the following changes this week, accompanied 
 by help pages and a note to sc-users.




 Index: Demand.sc
 ===================================================================
RCS file: /cvsroot/supercollider/SuperCollider3/build/SCClassLibrary/Common/ Audio/Demand.sc,v 
 retrieving revision 1.1
 diff -p -b -B -r1.1 Demand.sc
 *** Demand.sc   10 Apr 2004 19:49:49 -0000      1.1
 --- Demand.sc   6 Dec 2004 22:17:07 -0000
 *************** Demand : MultiOutUGen {
 *** 13,26 ****
   }

   Dseries : UGen {
 !       *new { arg start = 0, step = 1, length=100;
 !               ^this.multiNew('demand', start, step, length)
         }
   }

   Dgeom : UGen {
         *new { arg start = 1, grow = 2, length=100;
 !               ^this.multiNew('demand', start, grow, length)
         }
   }

 --- 13,26 ----
   }

   Dseries : UGen {
 !       *new { arg start = 1, step = 1, length = 100;
 !               ^this.multiNew('demand', length, start, step)
         }
   }

   Dgeom : UGen {
         *new { arg start = 1, grow = 2, length=100;
 !               ^this.multiNew('demand', length, start, grow)
         }
   }

 *************** Dswitch1 : UGen {
 *** 45,51 ****

   Dwhite : UGen {
         *new { arg lo, hi, length=inf;
 !               ^this.multiNew('demand', lo, hi, length)
         }
   }

 --- 45,51 ----

   Dwhite : UGen {
         *new { arg lo, hi, length=inf;
 !               ^this.multiNew('demand', length, lo, hi)
         }
   }

 *************** Diwhite : Dwhite {}
 *** 53,59 ****

   Dbrown : UGen {
         *new { arg lo, hi, step, length=inf;
 !               ^this.multiNew('demand', lo, hi, step, length)
         }
   }

 --- 53,59 ----

   Dbrown : UGen {
         *new { arg lo, hi, step, length=inf;
 !               ^this.multiNew('demand', length, lo, hi, step)
         }
   }

 --







 .
 _______________________________________________
 sc-dev mailing list
 sc-dev@xxxxxxxxxxxxxxx
 http://www.create.ucsb.edu/mailman/listinfo/sc-dev



 _______________________________________________
 sc-dev mailing list
 sc-dev@xxxxxxxxxxxxxxx
 http://www.create.ucsb.edu/mailman/listinfo/sc-dev



_______________________________________________
sc-dev mailing list
sc-dev@xxxxxxxxxxxxxxx
http://www.create.ucsb.edu/mailman/listinfo/sc-dev


--








.